PDA

View Full Version : IHC Changes



RichardGraham
09-15-2008, 11:59 PM
Hi Folks,

Take a look around the newly redesigned Inline Hockey Central and let us know what you like, and what you think could be improved.

Please notice the new blogs (there will be more), the video, the rotating new stories.

Hope you like what you see!

RichardGraham
09-16-2008, 12:08 AM
P.S. Let me know if you see what look to be "fuzzy" looking text or subheads. Mike Burke thinks I'm losing my eyesight, but I swear I'm seeing things that don't look right. ;)

hckypop02
09-16-2008, 12:52 AM
Looks good, I was on earlier then just returned and wow what a difference! Keep up the good work and GO NOR-CAL MUSTANGS!
Doug:)

Hoffer
09-16-2008, 07:02 PM
Looks good to me. The new front page looks awesome!

showtime89
09-16-2008, 08:12 PM
Is this part of PPS 2.0 or something IHC specific?

kevinsmithAZ
09-16-2008, 11:18 PM
Wow, the site looks great!

towson9
09-17-2008, 12:24 AM
Hi Folks,

Take a look around the newly redesigned Inline Hockey Central and let us know what you like, and what you think could be improved.

Please notice the new blogs (there will be more), the video, the rotating new stories.

Hope you like what you see!


are you tryin to compete with the "new facebook" that just came out haha j/k(personally the new facebook sucks to be honest)

looks good richard!

quick_dry
09-20-2008, 01:57 AM
hey Richard, could you change the way the forum pages are shown having multi-page threads sitting inside a frame.

It makes it really awkward to scroll down the page, with the 2 scrollbars, and I don't see that it serves any purpose since you could add the menuing and benner ads up the top on a regular vBulletin page like any other forum.

I like the new layout, but this one change would make it way more usable :)

RichardGraham
09-20-2008, 04:20 AM
Hi Quick_Dry,

I can do nothing of the sort!

However, Mike Burke may be able to. ;)

I'll ask him. Good suggestion. I've wondered about that myself.

MBurke
09-20-2008, 04:39 AM
hey Richard, could you change the way the forum pages are shown having multi-page threads sitting inside a frame.

It makes it really awkward to scroll down the page, with the 2 scrollbars, and I don't see that it serves any purpose since you could add the menuing and benner ads up the top on a regular vBulletin page like any other forum.

I like the new layout, but this one change would make it way more usable :)

This is not the intended effect. The frame is supposed to be resized based on the size of the related content within it. There should never be two scroll bars.

What OS/Browser/Resolution/etc. are you using?

InlineMBA
09-20-2008, 09:51 AM
This is not the intended effect. The frame is supposed to be resized based on the size of the related content within it. There should never be two scroll bars.

I always hated the two scroll bars.

Very nice job.

Steve Inge - ROXBURY 8

MBurke
09-20-2008, 10:07 AM
I always hated the two scroll bars.

Very nice job.

Steve Inge - ROXBURY 8

If something looks klunky and bad, I probably didn't mean to do it :D

Shoot me a message if any of you encounter things like this that you don't like or that look "off".

quick_dry
09-20-2008, 02:15 PM
I'm using IE7 on XP Pro, you test using a Gecko (e.g. firefox) or WebKit (e.g. Chrome, Safari) based browser?

It happens at any browser window size, the Iframe resize gets screwed up. I've heard of this being a problem, and a workable fix is to use a hidden iframe as a buffer to load content that gets displayed in a div. Example: http://www.dyn-web.com/tutorials/iframes/hidden.php

(Though wouldn't a better way be to avoid all the hocus-pocus and have all the banner and footer stuff ina template that gets put at the top/bottom of the page as regular html, rather than using iframes and stuff?)

It also seems to mess with the behaviour of opening a thread in a tab to a page other than the first page - this is in IE7 or Firefox* (currently v3.x but same behaviour on v2.x), instead of opening to the requested page of the thread it opens to page 1. Something funky in your URL fiddling function I guess.

* I don't have Chrome to see how a WebKit browser handles it.

MBurke
09-20-2008, 02:32 PM
I'm using IE7 on XP Pro, you test using a Gecko (e.g. firefox) or WebKit (e.g. Chrome, Safari) based browser?

It happens at any browser window size, the Iframe resize gets screwed up. I've heard of this being a problem, and a workable fix is to use a hidden iframe as a buffer to load content that gets displayed in a div. Example: http://www.dyn-web.com/tutorials/iframes/hidden.php


I test in a bunch of browsers (IE, FF, Safari and Opera mostly) when I do anything kind of sketchy like this, but I haven't been able to duplicate the problem you're having w/ the resize.



(Though wouldn't a better way be to avoid all the hocus-pocus and have all the banner and footer stuff ina template that gets put at the top/bottom of the page as regular html, rather than using iframes and stuff?)


Better, perhaps, but not easier. There's a ton of dynamic content that gets determined in the header and footer, most of it related to ad serving. Using a separate header and footer in the traditional vBulletin sense actually breaks the functionality of the ad server. There are some plugins but I haven't had a lot of time to investigate them.


It also seems to mess with the behaviour of opening a thread in a tab to a page other than the first page - this is in IE7 or Firefox* (currently v3.x but same behaviour on v2.x), instead of opening to the requested page of the thread it opens to page 1. Something funky in your URL fiddling function I guess.

Still trying to patch these up.

quick_dry
09-21-2008, 05:47 PM
yeah, I figured it was for the easier ad serving

if you open up a page from a multi-page thread (except the last page in thread) in IE then you should see it. this is what it looks like:

http://img339.imageshack.us/img339/1342/doublescrollbarcu1.jpg

quick_dry
09-21-2008, 06:16 PM
OK, so the problem is with the last line in the autofitIframe function:

parent.document.getElementById(id).style.height = frameHeight + "px";

I think it is an issue where javascript is being 'seen' in different contexts, and thus in one context it is fine, but not in the other. (Set a breakpoint on that line and it breaks there)

The showthread.php page has its doctype declared as:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

while the enclosing page does not have a doctype declared - and this is in when the error shows.

Interestingly, if you save the page (as html) in IE, it gives showthread page a doctype:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3c.org/TR/1999/REC-html401-19991224/loose.dtd">

and gives the enclosing page a doctype:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">

and the scrollbar problem does not appear, as the autofitIframe's last line fires properly (checked it both by obvious 'I observed the iframe fitting properly', and by it passing a breakpoint on that line in the debugger)

edit: a quick googling shows a bunch of links about iframe resizing needing the right DTDs to work properly.